Fix the secret for test bucket. #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roshan Khatri <[email protected]>
roshkhatri
requested review from
madolson and
hpatro
and removed request for
madolson
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1447 +/- ##
============================================
- Coverage 70.90% 70.79% -0.12%
============================================
Files 119 119
Lines 64631 64691 +60
============================================
- Hits 45828 45796 -32
- Misses 18803 18895 +92 |
madolson
approved these changes
Dec 16, 2024
hpatro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have set the secret as
AWS_S3_TEST_BUCKETfor test bucket and I missed it in the initial review.