-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for lt
and gt
in isInt()
.
#588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the README?
@@ -4,6 +4,7 @@ | |||
([#585](https://github.com/chriso/validator.js/pull/585)) | |||
- Added support for greater or less than in `isFloat()` | |||
([#544](https://github.com/chriso/validator.js/issues/544)) | |||
- Added support for `lt` and `gt` into `isInt()`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the following:
- Added support for `lt` and `gt` into `isInt()`
([#588](https://github.com/chriso/validator.js/pull/588))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done and done.
@chriso, I made those changes to the |
According to the diff, you've updated the CHANGELOG but not the README. |
Sorry, didn't see that. On it. |
Also updated README.md
@chriso: I think I got it. |
@@ -1,3 +1,9 @@ | |||
#### HEAD | |||
- Added support for greater or less than in `isFloat()` | |||
([#544](https://github.com/chriso/validator.js/issues/544)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these two lines please. The isFloat()
change was not part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh! Too much copy-and-paste in the merge conflict resolution. Done.
Thanks. |
We want to be able to use
lt
andgt
in theisInt()
function. This is just adding that in. I added unit tests.