-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(isMobilePhone): update phone regex for Zambia #2037
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2037 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 104 104
Lines 2203 2308 +105
Branches 477 578 +101
==========================================
+ Hits 2203 2308 +105
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi @imkrishh, thanks for the PR. It looks like currently only the following ranges are assigned and valid, which your PR is implementing, so thanks! Also another reference for the future: https://goo.gl/maps/YbE5RygVAwBarQhj7 Justone thing, that I think still needs to be done ideally: Thanks! for future reference: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you.
looks good to me now :-)
However please note, I don't have any privileges in this project, so we will have to wait for two of the maintainers to review and merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. can fix the merge conflict if possible, or I'll fix them during clean-up.
@imkrishh can you fix the merge conflicts |
Conflict fixed here - #2482 |
Updated Zambia phone number RegEx validator
Added support for new phone network provider for Zambia [ref-link]
077 - Airtel (New Serial #)
076 - MTN (New Serial #)
Checklist