Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): Added regex for Bahamas - en-BS #1940

Merged

Conversation

savannahvaith
Copy link
Contributor

@savannahvaith savannahvaith commented Mar 15, 2022

feat(isMobilePhone): added regex for Bahamas - en-BS

Added Bahamas telephone regex to mobile list
Adding to issue #1761

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1940 (3d7fd6a) into master (c1b21a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1940   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2085      2085           
  Branches       472       472           
=========================================
  Hits          2085      2085           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b21a9...3d7fd6a. Read the comment docs.

@savannahvaith
Copy link
Contributor Author

hey @ezkemboi could I get some eyes on this PR please?

@rubiin
Copy link
Member

rubiin commented Jul 18, 2022

@savannahvaith please fix conflicts

@rubiin rubiin added the mc-to-land Just merge-conflict standing between the PR and landing. label Jul 18, 2022
@rubiin rubiin merged commit aead076 into validatorjs:master Jul 19, 2022
@rubiin
Copy link
Member

rubiin commented Jul 19, 2022

Thankyou for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants