Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add passport number of thailand #1814

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Conversation

TonPC64
Copy link
Contributor

@TonPC64 TonPC64 commented Oct 19, 2021

feat(isPassportNumber): add passport number format of thailand

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Screen Shot 2564-10-20 at 03 38 41

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1814 (57a90cf) into master (1bb14e8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1814   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2203      2203           
  Branches       477       477           
=========================================
  Hits          2203      2203           
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb14e8...57a90cf. Read the comment docs.

@TonPC64
Copy link
Contributor Author

TonPC64 commented Oct 20, 2021

@tux-tn doesn’t have issues, but it good to improve this feture

README.md Outdated Show resolved Hide resolved
kasir-barati
kasir-barati previously approved these changes Mar 29, 2022
@kasir-barati
Copy link

@braaar @TonPC64 @chuyeow @boutell Why the PR is blocked?
Please merge it

@rubiin
Copy link
Member

rubiin commented Jul 27, 2022

@TonPC64 pleaes fix merge

@rubiin rubiin self-requested a review July 27, 2022 06:58
@rubiin rubiin added the mc-to-land Just merge-conflict standing between the PR and landing. label Jul 27, 2022
@TonPC64
Copy link
Contributor Author

TonPC64 commented Jul 27, 2022

@rubiin fixed

@rubiin rubiin added ready-to-land For PRs that are reviewed and ready to be landed and removed mc-to-land Just merge-conflict standing between the PR and landing. labels Jul 27, 2022
@TonPC64
Copy link
Contributor Author

TonPC64 commented Oct 1, 2022

@rubiin please merge this pr

@TonPC64 TonPC64 requested review from kasir-barati and braaar and removed request for kasir-barati and braaar October 15, 2022 09:32
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@profnandaa profnandaa merged commit edf445a into validatorjs:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants