-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Poland Country Code #1809
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1809 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2029 2029
Branches 457 457
=========================================
Hits 2029 2029
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR @Ronqn ! Mostly LGTM. Please check and address my comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 ! Don't know why github showed my an old revision of your README.md
Thanks for accepting, I noticed the typo after replacing and quickly fixed it, the check probably bugged at that time :-) 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch! 🎉
* Updated Poland Country Code * Updated PO to PL in validator.js * Changed PO to PL in README.md * Typo in README.md Co-authored-by: Ronan Doudiès <[email protected]>
* Updated Poland Country Code * Updated PO to PL in validator.js * Changed PO to PL in README.md * Typo in README.md Co-authored-by: Ronan Doudiès <[email protected]>
* Updated Poland Country Code * Updated PO to PL in validator.js * Changed PO to PL in README.md * Typo in README.md Co-authored-by: Ronan Doudiès <[email protected]>
Updated the country code of Poland from PO to PL.
Checklist
Fixes #1806
EDIT : First check failed because I forgot to edit the validator.js file. All good now!
EDIT 2 : Also updated README.md... my bad