Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isMobilePhone Regular Expression for Vietnamese phone number #1689

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

luisrivas
Copy link
Contributor

@luisrivas luisrivas commented Jul 4, 2021

According to this Vietnam phone number guide, we should accept 11 length phone numbers as valid when the number starts with the 84 country code. In addition, I am adding the 55 area code.

Closes #813

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the merge conflicts and we should be good to go.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #1689 (c0f9b3c) into master (01eeaef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1689   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          101       101           
  Lines         1862      1862           
=========================================
  Hits          1862      1862           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01eeaef...c0f9b3c. Read the comment docs.

@luisrivas
Copy link
Contributor Author

Fixed! @profnandaa

@luisrivas luisrivas requested a review from profnandaa July 16, 2021 13:44
@profnandaa profnandaa merged commit e08e79a into validatorjs:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isMobilePhone not valid number phone in VietNam
2 participants