-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IP version 4 or 6 for isIPRange function #1594
Add support for IP version 4 or 6 for isIPRange function #1594
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1594 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1807 1820 +13
=========================================
+ Hits 1807 1820 +13
Continue to review full report at Codecov.
|
Nice one ! Need this too |
Would this be a duplicate of #1568? Yours looks like it's a more complete solution though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. Thank you @neilime for your contribution! I really like your approach and the fact that you used the same logic behind isIP
.
Can you please remove validator.js
and validator.min.js
(We stopped tracking those files in the library) and discard the unrelated changes in src/lib/isMobilePhone
?
Thank you 🎉
@tux-tn I have rebased with master, let me know if everything looks good to you |
@neilime LGTM ! thank you for making the necessary changes 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contrib! 🎉
At the moment,
isIPRange
function only supports IP v4, this PR allows to choose v4 or v6 or both (likeisIP
function)Checklist