-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for isFQDN wth numeric domain names #1546
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 99 99
Lines 1773 1773
=========================================
Hits 1773 1773
Continue to review full report at Codecov.
|
Fixes #1543 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
Can we get a release out to npm? @profnandaa |
13.5.2 is now published on NPM as hotfix. Here is the hotfix branch too - /cc. @niftylettuce @andyli9449 @mbalaam - please let's know if all looks good. |
Hello
Checklist