Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isPostalCode): support for IR locale #1515

Merged
merged 1 commit into from
Nov 29, 2020

Conversation

masoudDaliriyan
Copy link
Contributor

@masoudDaliriyan masoudDaliriyan commented Nov 3, 2020

{{ briefly describe what you have done in this PR }}

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #1515 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1515   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          96       96           
  Lines        1277     1277           
=======================================
  Hits         1276     1276           
  Misses          1        1           
Impacted Files Coverage Δ
src/lib/isPostalCode.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab507a...3ac4e3c. Read the comment docs.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update the README too. Thanks for your contrib! 🎉

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Nov 19, 2020
@masoudDaliriyan
Copy link
Contributor Author

LGTM, please update the README too. Thanks for your contrib! 🎉

@profnandaa IR locale already was existed on REDME.

Screen Shot 2020-11-19 at 18 56 37

@profnandaa
Copy link
Member

profnandaa commented Nov 19, 2020 via email

@masoudDaliriyan
Copy link
Contributor Author

@profnandaa please remove needs-update tag

@profnandaa profnandaa removed the 🧹 needs-update For PRs that need to be updated before landing label Nov 29, 2020
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants