-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isPostalCode): support for IR locale #1515
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1515 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 96 96
Lines 1277 1277
=======================================
Hits 1276 1276
Misses 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please update the README too. Thanks for your contrib! 🎉
@profnandaa IR locale already was existed on REDME. |
oh, got it, thx
On Thu, Nov 19, 2020 at 6:33 PM msdDaliriyan ***@***.***> wrote:
LGTM, please update the README too. Thanks for your contrib! 🎉
@profnandaa <https://github.com/profnandaa> IR locale already was existed
on REDME.
[image: Screen Shot 2020-11-19 at 18 56 37]
<https://user-images.githubusercontent.com/25932831/99686996-65ba4080-2a99-11eb-9758-b882cb2781f2.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1515 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB7ZEKRUHYV52D3ESH2JSTSQU3GHANCNFSM4TJJ3KAA>
.
--
Sent from a tiny device while on the move.
|
@profnandaa please remove needs-update tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution.
{{ briefly describe what you have done in this PR }}
Checklist