feature: Oman mobile phone validation added to isMobilePhone #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1506 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 99 99
Lines 1773 1773
=========================================
Hits 1773 1773
Continue to review full report at Codecov.
|
profnandaa
approved these changes
Nov 19, 2020
|
Pls fix the merge conflicts. |
profnandaa
added
the
🧹 needs-update
|
@profnandaa conflicts resolved. |
profnandaa
approved these changes
Dec 1, 2020
|
Much needed PR, Thanks @dev-sna 👍 |
|
Awesome addition to the library @dev-sna 👍 |
profnandaa
removed
the
🧹 needs-update
|
Thanks for creating this, was much needed @dev-sna |
|
@profnandaa By when is the team releasing this? |
|
@abdulmoizeng a new release is planned before the end of this month |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for validation of Oman's mobile phone numbers to isMobilePhone validator.
Checklist