feat(isISO8601): Add new option to isISO8601 that checks if date and time are strictly separated by a T
#1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestone51
changed the title
T
Codecov Report
@@ Coverage Diff @@
## master #1486 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 96 96
Lines 1286 1287 +1
=======================================
+ Hits 1285 1286 +1
Misses 1 1
Continue to review full report at Codecov.
|
|
Any chance of this seeing a review anytime soon? |
|
It has been 22 days since I submitted this Pr -- have i done something incorrectly? I've seen several other PRs get reviewed that were submitted after this one. |
|
@brostone51 -- sorry for the delay on reviewing this, on it now. |
…into is-iso8601-strict-separator
profnandaa
approved these changes
Nov 19, 2020
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the Wikipedia entry for ISO8601, the
Tthat separates date and time is required. However, separating date and time by another character (such as whitespace,\s, in the current regular expression) is allowed by RFC 3339.In order to not break any existing dependent code, I have added a new option to
isISO8601that allows the user to passstrictSeparator = truein the options. This would validate the date time string to always have the date and time separated by the literalT.Checklist