Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isFQDN): allow all-underscore labels with allow_underscores (#1253) #1469

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

gibson042
Copy link
Contributor

Update isFQDN to allow domain names with all-underscore labels when allow_underscores is true. Underscore is not allowed in LDH "preferred name syntax" host names, but may appear anywhere in generic domain name labels (cf. RFC 8499).

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #1469 (6bb6b93) into master (a19ebff) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1469   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          96       96           
  Lines        1286     1286           
=======================================
  Hits         1285     1285           
  Misses          1        1           
Impacted Files Coverage Δ
src/lib/isFQDN.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19ebff...06b1a42. Read the comment docs.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. pls fix the merge conflict and we should be good to go. Thanks for your contrib! 🎉

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Nov 15, 2020
@gibson042 gibson042 force-pushed the gh-1253-isFQDN-underscore branch from d62d294 to 06b1a42 Compare November 16, 2020 18:38
@gibson042
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants