Implement isPassportNumber Validator #1250

hamzahejja · 2020-02-16T17:13:37Z

Per issue Validator for passport numbers #1218 , This PR introduces an implementation to: isPassportNumber(str, countryCode) validator, which validates the input string against a passport no. regex that corresponds to the passed-in ISO country code 🎉

References:

ISO Country Code(s) Worldwide
EU Passport Number(s) Format/Pattern.
Wikipedia
Tests are added per country, testing valid/invalid string(s) for validity.

hamzahejja · 2020-02-16T17:46:50Z

@profnandaa Have a look at it when you're free to 👍

hamzahejja · 2020-02-16T17:47:32Z

@dani2819 Abdullah -- FYI ☝️

profnandaa

Solid work on this Hamza, thanks! Few comments:

add a few test cases
remove the stray code indicated

profnandaa · 2020-02-16T20:17:04Z

validator.js

@@ -402,7 +402,7 @@ function isFQDN(str, options) {
   to the 5th link, and "interface10" belongs to the 10th organization.
 * * */

-var ipv4Maybe = /^(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})$/;
+var ipv4Maybe = /^(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\.){3}([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])$/;


can remove this unrelated change.

profnandaa · 2020-02-16T20:17:13Z

validator.js

@@ -848,6 +848,17 @@ function isBoolean(str) {
  return ['true', 'false', '1', '0'].indexOf(str) >= 0;
 }

+var localeReg = /^[A-z]{2,4}([_-]([A-z]{4}|[\d]{3}))?([_-]([A-z]{2}|[\d]{3}))?$/;


hamzahejja · 2020-02-16T21:59:48Z

validator.js

@@ -2420,6 +2524,7 @@ var validator = {
  isJSON: isJSON,
  isEmpty: isEmpty,
  isLength: isLength,
+  isLocale: isLocale,


@profnandaa Should this be removed as well ?

Yes, please -- all the unrelated diff.

hamzahejja · 2020-02-16T22:00:03Z

index.js

@@ -35,12 +35,16 @@ var _isFQDN = _interopRequireDefault(require("./lib/isFQDN"));

 var _isBoolean = _interopRequireDefault(require("./lib/isBoolean"));

+var _isLocale = _interopRequireDefault(require("./lib/isLocale"));


@profnandaa Remove this ?

hamzahejja · 2020-02-16T22:00:10Z

index.js

@@ -227,6 +232,7 @@ var validator = {
  isJSON: _isJSON.default,
  isEmpty: _isEmpty.default,
  isLength: _isLength.default,
+  isLocale: _isLocale.default,


@profnandaa Should be removed ?

hamzahejja · 2020-02-16T22:02:38Z

test/validators.js

@@ -1853,6 +1853,522 @@ describe('Validators', () => {
    });
  });

+  it('should validate passport number', () => {


@profnandaa Check here for the tests, I've already included test-cases, one per country code. It's a Large diff, it had be manually loaded, probably that's why you didn't notice it

My bad missed that.

tux-tn · 2020-02-17T16:58:16Z

Great job @hamzahejja 🎉

profnandaa · 2020-02-17T19:04:05Z

test/validators.js

@@ -1853,6 +1853,522 @@ describe('Validators', () => {
    });
  });

+  it('should validate passport number', () => {


My bad missed that.

hamzahejja · 2020-02-17T19:11:26Z

README.md

@@ -140,6 +140,7 @@ Validator                               | Description
 **isMultibyte(str)**                    | check if the string contains one or more multibyte chars.
 **isNumeric(str [, options])**                      | check if the string contains only numbers.<br/><br/>`options` is an object which defaults to `{no_symbols: false}`. If `no_symbols` is true, the validator will reject numeric strings that feature a symbol (e.g. `+`, `-`, or `.`).
 **isOctal(str)**                        | check if the string is a valid octal number.
+**isPassportNumber(str, countryCode)    | check if the string is a valid passport number relative to a specific country code.


@profnandaa Could you just update README.md at master branch and change/fix this line to the correct styling, i.e.
**isPassportNumber(str, countryCode)**

Oops, will do that.

hamzahejja added 3 commits February 16, 2020 19:08

feat: implement isPassportNumber validator

c99c4e1

normalize str by cleaning spaces and converting to UPPERCASE

ec67553

style: function docs, helper comments

9d10e0c

hamzahejja requested a review from profnandaa February 16, 2020 17:45

profnandaa requested changes Feb 16, 2020

View reviewed changes

remove unrelated changes

8ccc0f1

hamzahejja commented Feb 16, 2020

View reviewed changes

profnandaa approved these changes Feb 17, 2020

View reviewed changes

profnandaa merged commit 9836c29 into validatorjs:master Feb 17, 2020

hamzahejja deleted the add-isPassportNumber-validator branch February 17, 2020 19:06

hamzahejja commented Feb 17, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement isPassportNumber Validator #1250

Implement isPassportNumber Validator #1250

hamzahejja commented Feb 16, 2020 •

edited

Loading

hamzahejja commented Feb 16, 2020 •

edited

Loading

hamzahejja commented Feb 16, 2020

profnandaa left a comment

profnandaa Feb 16, 2020

profnandaa Feb 16, 2020

hamzahejja Feb 16, 2020

profnandaa Feb 17, 2020

hamzahejja Feb 16, 2020

hamzahejja Feb 16, 2020

hamzahejja Feb 16, 2020

profnandaa Feb 17, 2020

tux-tn commented Feb 17, 2020

profnandaa Feb 17, 2020

hamzahejja Feb 17, 2020 •

edited

Loading

profnandaa Feb 17, 2020

		@@ -35,12 +35,16 @@ var _isFQDN = _interopRequireDefault(require("./lib/isFQDN"));

		var _isBoolean = _interopRequireDefault(require("./lib/isBoolean"));

		var _isLocale = _interopRequireDefault(require("./lib/isLocale"));

Implement isPassportNumber Validator #1250

Implement isPassportNumber Validator #1250

Conversation

hamzahejja commented Feb 16, 2020 • edited Loading

hamzahejja commented Feb 16, 2020 • edited Loading

hamzahejja commented Feb 16, 2020

profnandaa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tux-tn commented Feb 17, 2020

Choose a reason for hiding this comment

hamzahejja Feb 17, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hamzahejja commented Feb 16, 2020 •

edited

Loading

hamzahejja commented Feb 16, 2020 •

edited

Loading

hamzahejja Feb 17, 2020 •

edited

Loading