Reject URLs that are protocol only, closes #642

validatorjs · Jul 7, 2017 · fdea1d7 · fdea1d7
1 parent cc96615
commit fdea1d7
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 - `isURL()` now requires the `require_tld: false` option to validate `localhost`
   ([#675](https://github.com/chriso/validator.js/issues/675))
+- `isURL()` now rejects URLs that are protocol only
+  ([#642](https://github.com/chriso/validator.js/issues/642))
 
 #### 7.2.0
 

diff --git a/lib/isURL.js b/lib/isURL.js
@@ -87,6 +87,10 @@ function isURL(url, options) {
   }
   url = split.join('://');
 
+  if (url === '') {
+    return false;
+  }
+
   split = url.split('/');
   url = split.shift();
 

diff --git a/src/lib/isURL.js b/src/lib/isURL.js
@@ -61,6 +61,10 @@ export default function isURL(url, options) {
   }
   url = split.join('://');
 
+  if (url === '') {
+    return false;
+  }
+
   split = url.split('/');
   url = split.shift();
 

diff --git a/test/validators.js b/test/validators.js
@@ -325,6 +325,7 @@ describe('Validators', function () {
       ],
       invalid: [
         'http://foobar.com',
+        'file://',
       ],
     });
   });

diff --git a/validator.js b/validator.js
@@ -364,6 +364,10 @@ function isURL(url, options) {
   }
   url = split.join('://');
 
+  if (url === '') {
+    return false;
+  }
+
   split = url.split('/');
   url = split.shift();
 

diff --git a/validator.min.js b/validator.min.js
-Original file line number
+Diff line change
@@ Expand Up / @@ -325,6 +325,7 @@ describe('Validators', function () { @@
           ],
           invalid: [
             'http://foobar.com',
+            'file://',
           ],
         });
       });
@@ Expand Down @@