fix(isFloat): fix comma passing as float (#2174)

Co-authored-by: Frederike Ramin <[email protected]>
validatorjs · Feb 2, 2023 · 4b06c0e · 4b06c0e
1 parent 58f4b13
commit 4b06c0e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/lib/isFloat.js b/src/lib/isFloat.js
@@ -5,7 +5,7 @@ export default function isFloat(str, options) {
   assertString(str);
   options = options || {};
   const float = new RegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);
-  if (str === '' || str === '.' || str === '-' || str === '+') {
+  if (str === '' || str === '.' || str === ',' || str === '-' || str === '+') {
     return false;
   }
   const value = parseFloat(str.replace(',', '.'));

diff --git a/test/validators.test.js b/test/validators.test.js
@@ -4122,6 +4122,7 @@ describe('Validators', () => {
         '  ',
         '',
         '.',
+        ',',
         'foo',
         '20.foo',
         '2020-01-06T14:31:00.135Z',
-Original file line number
+Diff line change
@@ Expand Up / @@ -4122,6 +4122,7 @@ describe('Validators', () => { @@
             '  ',
             '',
             '.',
+            ',',
             'foo',
             '20.foo',
             '2020-01-06T14:31:00.135Z',
@@ Expand Down @@