Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE-REQUEST] Support Google Colab installation without runtime restart #2211

Closed
franz101 opened this issue Sep 20, 2022 · 6 comments
Closed

Comments

@franz101
Copy link
Contributor

Description
When running pip install vaex, the runtime of the colab is needed to restarted (see attachments)

Is your feature request related to a problem? Please describe.
The problem is some dependencies update matplotlib to larger then 3.22 (which runs on Google Colab)
Additional context
Here is a Google Colab that shows the problem and a workaround

Example of runtime restart needed:
Screenshot 2022-09-20 at 15 27 03

Example of installing the packages in a way matplotlib is not updated:
Screenshot 2022-09-20 at 15 27 56

@franz101
Copy link
Contributor Author

@maartenbreddels

@JovanVeljanoski
Copy link
Member

JovanVeljanoski commented Sep 20, 2022

I don't think we can do anything about that. It is their environment.

If somebody has an idea on how to fix this - please get in touch.

Edit: If you do not want to update or touch matplotlib in any way, just don't install vaex-viz. Install only vaex-core and perhaps vaex-hdf5 and vaex-ml depending on what you need.

@maartenbreddels
Copy link
Member

Strange issue, thanks for letting us know.

Maybe by using the solution here geoalchemy/geoalchemy2#392 in vaex (instead of the slow pkg_resources) we can make this faster and also working on colab without requiring a restart.

I think this could be a good first issue for someone.

@franz101
Copy link
Contributor Author

Hey @maartenbreddels ,

thanks for the input. I have forked vaex and am experimenting with the different version implementation:
https://github.com/franz101/vaex-colab/blob/f70f4a4e2ef6c4d2902239e183f5d7abd4bcc4d3/packages/vaex-core/vaex/version.py

But running the installation it fails during the vaex-meta setup:
https://colab.research.google.com/drive/1WC-ROEunPKaxHD50b_vqxHS_3FT9METM#scrollTo=apSprOWRQ2qy

is this related to python 3.7 and not a venv?

@franz101
Copy link
Contributor Author

franz101 commented Oct 11, 2022

Running setup.py develop for vaex-meta worked after cloning recursively

maartenbreddels pushed a commit that referenced this issue Nov 11, 2022
* moving to importlib

* attribution

* Update version.py

* Update pythonpackage.yml

* Update pythonpackage.yml

* added non failing version check

* fix indentation
@maartenbreddels
Copy link
Member

Yeah, we could improve there by giving a hint if the git submodules are empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants