Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if config doesn't exist, add minimal one with flowLayout #2793

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Oct 4, 2024

When Hilla view has no config, make sure to create a minimal config for it, containing the flowLayout value.

Fixes vaadin/flow#20110

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (29cd084) to head (e7122a0).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2793   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files          81       81           
  Lines        2673     2675    +2     
  Branches      683      685    +2     
=======================================
+ Hits         2467     2469    +2     
  Misses        156      156           
  Partials       50       50           
Flag Coverage Δ
unittests 92.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 4, 2024

@tepi tepi merged commit 2f3dee9 into main Oct 4, 2024
15 checks passed
@tepi tepi deleted the fix/add-default-config branch October 4, 2024 11:54
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.5.0.beta6 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hilla view does not render inside Flow layout if it has no view config
4 participants