Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window cannot be dragged when using touch screen #12257

Closed
Jantoni1 opened this issue Mar 29, 2021 · 2 comments · Fixed by #12260
Closed

Window cannot be dragged when using touch screen #12257

Jantoni1 opened this issue Mar 29, 2021 · 2 comments · Fixed by #12260
Labels
bug

Comments

@Jantoni1
Copy link
Contributor

  • Vaadin version: 8.11.0
  • Browser version: Chrome 89.0.4389.82
  • Web container: Tomcat 8
  • Bug description: When using a touch screen device, the user cannot drag the window by dragging the header.
  • Minimal reproducible example
  • Expected behavior: when touching and moving the finger, the user should be able to drag the window
  • Actual behavior: nothing happens
  • Steps to reproduce: Enable mobile device preview (e.g. in Chrome) and try to move the window by dragging the header.
Jantoni1 pushed a commit to Jantoni1/framework that referenced this issue Mar 29, 2021
vaadin#12257
2f156f7 
added check for touch move event in order to allow the same flow for both mouse and touch events window drag
@Jantoni1 Jantoni1 mentioned this issue Mar 29, 2021
Closed
Jantoni1 added a commit to Jantoni1/framework that referenced this issue Mar 29, 2021
@Jantoni1
vaadin#12257 added check for touch move event in order to allow the s…
62b105d 
…ame flow for both mouse and touch events window drag
@TatuLund TatuLund added the bug label Mar 30, 2021
@TatuLund
Copy link
Contributor

This is trivial to reproduce on demo.vaadin.com/sampler using Windows 10 2-in-1 device.

Ansku pushed a commit to Ansku/framework that referenced this issue Mar 30, 2021
@Jantoni1 @Ansku
Fix Window dragging on touch screen.
cd3af8b 
- Added check for touch move event in order to allow the same flow for
both mouse and touch events when dragging a Window by its header.
- Can be tested with SubwindowDraggability class.

Fixes vaadin#12257
@Ansku Ansku mentioned this issue Mar 30, 2021
Merged
OlliTietavainenVaadin pushed a commit that referenced this issue Mar 31, 2021
@Ansku @Jantoni1
Fix Window dragging on touch screen. (#12260)
e30226a 
- Added check for touch move event in order to allow the same flow for
both mouse and touch events when dragging a Window by its header.
- Can be tested with SubwindowDraggability class.

Fixes #12257

Co-authored-by: Jakub Antoniak <[email protected]>
@TatuLund
Copy link
Contributor

TatuLund commented Mar 31, 2021 •
edited
Loading

Just a not. For some weird reason this bug was fixed in Vaadin 7.6.6 #6790

The fix was overwritten by another fix dfcc494

Thus the bug is regression from this.

Ansku added a commit that referenced this issue Apr 13, 2021
@Ansku @Jantoni1
Fix Window dragging on touch screen. (#12260)
af89654 
- Added check for touch move event in order to allow the same flow for
both mouse and touch events when dragging a Window by its header.
- Can be tested with SubwindowDraggability class.

Fixes #12257

Co-authored-by: Jakub Antoniak <[email protected]>
@Ansku Ansku mentioned this issue Apr 13, 2021
Merged
OlliTietavainenVaadin pushed a commit that referenced this issue Apr 13, 2021
@Ansku @Jantoni1
Fix Window dragging on touch screen. (#12260) (#12264)
e8c78e6 
* Fix Window dragging on touch screen. (#12260)

- Added check for touch move event in order to allow the same flow for
both mouse and touch events when dragging a Window by its header.
- Can be tested with SubwindowDraggability class.

Fixes #12257

Co-authored-by: Jakub Antoniak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Window dragging on touch screen. Ansku/framework
2 participants
@TatuLund @Jantoni1