Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: makes HttpClient instance available for garbage collection #20746

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

chore: makes HttpClient instance available for garbage collection #20746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...dev-server/src/main/java/com/vaadin/base/devserver/viteproxy/ViteWebsocketConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ public class ViteWebsocketConnection implements Listener {

private final Consumer<String> onMessage;
private final Runnable onClose;
private final CompletableFuture<WebSocket> clientWebsocket = new CompletableFuture<>();
private final List<CharSequence> parts = new ArrayList<>();
private CompletableFuture<WebSocket> clientWebsocket = new CompletableFuture<>();

private static Logger getLogger() {
return LoggerFactory.getLogger(ViteWebsocketConnection.class);
Expand Down Expand Up @@ -169,6 +169,9 @@ public void close() throws InterruptedException, ExecutionException {
// Websocket client connection has not been established
clientWebsocket.cancel(true);
}
// release HttpClient reference, so its internal executor can be
// properly stopped
clientWebsocket = null;
}

@Override
Expand Down
Loading