feat: Add interfaces for CRUD services #20743
Conversation
Artur-
force-pushed
the
crud-interfaces
branch
from
b433077 to
83ece96
Compare
These were previously in Hilla but are equally useful in Flow applications
Artur-
force-pushed
the
crud-interfaces
branch
from
83ece96 to
8ebca25
Compare
vaadin-spring/src/main/java/com/vaadin/flow/spring/data/jpa/CrudRepositoryService.java
Outdated
Show resolved
Hide resolved
vaadin-spring/src/main/java/com/vaadin/flow/spring/data/jpa/JpaFilterConverter.java
Outdated
Show resolved
Hide resolved
...-spring/src/main/java/com/vaadin/flow/spring/data/jpa/PropertyStringFilterSpecification.java
Outdated
Show resolved
Hide resolved
vaadin-spring/src/main/java/com/vaadin/flow/spring/data/jpa/JpaFilterConverter.java
Outdated
Show resolved
Hide resolved
|
| * @return the fresh object or {@code null} if no object was found to update | ||
| */ | ||
| @Nullable | ||
| T save(T value); |
There was a problem hiding this comment.
Any particular reason for returning null instead of using an Optional or throwing an exception?
| @@ -0,0 +1,2 @@ | |||
| @org.springframework.lang.NonNullApi | |||
| package com.vaadin.flow.spring.data.jpa; | |||
There was a problem hiding this comment.
Maybe also add @NullMarked from JSpecify?
| @@ -0,0 +1,2 @@ | |||
| @org.springframework.lang.NonNullApi | |||
| package com.vaadin.flow.spring.data; | |||
| * the filter to apply or {@code null} to not filter | ||
| * @return a list of objects or an empty list if no objects were found | ||
| */ | ||
| @NonNull |
There was a problem hiding this comment.
Are the @NonNull annotations here because of Hilla's code generator? I guess Hilla does not understand @NonNullApi / @NullMarked on a parent interface?
| @JsonSubTypes({ @Type(value = OrFilter.class, name = "or"), | ||
| @Type(value = AndFilter.class, name = "and"), | ||
| @Type(value = PropertyStringFilter.class, name = "propertyString") }) | ||
| public class Filter implements Serializable { |
There was a problem hiding this comment.
Are the Filter classes meant to mainly be created by Jackson, or is there a situation where a developer may want to create them in Java as well? Also why are the Filter classes mutable and not immutable?
| @@ -0,0 +1,2 @@ | |||
| @org.springframework.lang.NonNullApi | |||
There was a problem hiding this comment.
Consider adding @NullMarked here.
| */ | ||
| public List<T> saveAll(Iterable<T> values) { | ||
| List<T> saved = new ArrayList<>(); | ||
| getRepository().saveAll(values).forEach(saved::add); |
There was a problem hiding this comment.
Maybe use List.copyOf(..) instead here?
| import com.vaadin.flow.spring.data.filter.PropertyStringFilter; | ||
| import org.springframework.data.jpa.domain.Specification; | ||
|
|
||
| public class PropertyStringFilterSpecification<T> implements Specification<T> { |
There was a problem hiding this comment.
Could this be package private, or is there any situation where you would want to manually instantiate it or extend it?
These were previously in Hilla but are equally useful in Flow applications