Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not log incompatibility if project dependencies are not resolved (#20682) (CP: 24.6) #20701

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

…olved (#20682)

Depending on the phase maven goals are executed, the project dependencies
might not have been resolved, making the Flow incompatibility log message
useless (e.g when running clean-frontend).
This change prevents the message to be printed if project Flow version
cannot be detected.
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) December 13, 2024 14:12
Copy link

sonarcloud bot commented Dec 13, 2024

Copy link

github-actions bot commented Dec 13, 2024

Test Results

1 159 files  ± 0  1 159 suites  ±0   1h 30m 54s ⏱️ - 2m 34s
7 554 tests ± 0  7 500 ✅ ± 0  54 💤 ±0  0 ❌ ±0 
7 890 runs   - 37  7 827 ✅  - 37  63 💤 ±0  0 ❌ ±0 

Results for commit 0f823ce. ± Comparison against base commit 2471bd1.

♻️ This comment has been updated with latest results.

@vaadin-bot vaadin-bot merged commit 7c7c710 into 24.6 Dec 13, 2024
26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20682-to-24.6-1734098558793 branch December 13, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants