Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch exceptions from detach calls (#20656) (CP: 24.6) #20698

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

* fix: catch exceptions from detach calls

* add test

---------

Co-authored-by: Marco Collovati <[email protected]>
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) December 13, 2024 14:08
Copy link

Test Results

1 159 files  ± 0  1 159 suites  ±0   1h 29m 25s ⏱️ - 4m 3s
7 555 tests + 1  7 501 ✅ + 1  54 💤 ±0  0 ❌ ±0 
7 888 runs   - 39  7 827 ✅  - 37  61 💤  - 2  0 ❌ ±0 

Results for commit 71c5bf7. ± Comparison against base commit 2471bd1.

@vaadin-bot vaadin-bot merged commit ad53c65 into 24.6 Dec 13, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20656-to-24.6-1734098268301 branch December 13, 2024 14:18
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants