Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add a new maven module for Full-Stack Signals common lib #20694

Merged
merged 3 commits into from
Dec 13, 2024
Merged

chore: Add a new maven module for Full-Stack Signals common lib #20694

merged 3 commits into from
Dec 13, 2024

Conversation

mshabarov
Copy link
Contributor

@mshabarov mshabarov commented Dec 13, 2024 •
edited
Loading

Adds a new empty maven module for Full-Stack Signals common lib for Flow and Hilla

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Test Results

1 159 files  ± 0  1 159 suites  ±0   1h 29m 6s ⏱️ - 3m 5s
7 556 tests ± 0  7 502 ✅ ± 0  54 💤 ±0  0 ❌ ±0 
7 884 runs   - 16  7 821 ✅  - 18  63 💤 +2  0 ❌ ±0 

Results for commit bdc1f59. ± Comparison against base commit 64efd11.

♻️ This comment has been updated with latest results.

taefi
taefi requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@taefi taefi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this module depend on a flow module? Or was it the other way around?

flow-signals/pom.xml Outdated Show resolved Hide resolved
@mshabarov mshabarov requested a review from taefi December 13, 2024 13:36
taefi
taefi approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taefi taefi enabled auto-merge (squash) December 13, 2024 14:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
39 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@taefi taefi merged commit 9982c05 into main Dec 13, 2024
24 of 26 checks passed
@taefi taefi deleted the new-signal-module branch December 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taefi taefi taefi approved these changes

Assignees
No one assigned
Labels
+0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshabarov @taefi @vaadin-bot