Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigatin to client view from server #20151

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Oct 7, 2024

Navigation to the client view
using server navigate should
work normally and not try to
add layout for non layout
client view.

Navigation to the client view
using server navigate should
work normally and not try to
add layout for non layout
client view.
Copy link

github-actions bot commented Oct 7, 2024

Test Results

1 141 files  ± 0  1 141 suites  ±0   1h 8m 31s ⏱️ - 4m 3s
7 440 tests ± 0  7 390 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 742 runs   - 35  7 682 ✅  - 37  60 💤 +2  0 ❌ ±0 

Results for commit 54cc937. ± Comparison against base commit 27d1f92.

♻️ This comment has been updated with latest results.

@caalador caalador marked this pull request as ready for review October 7, 2024 08:51
@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels Oct 7, 2024
@mshabarov mshabarov requested a review from tltv October 7, 2024 11:41
@vaadin-bot vaadin-bot added +0.0.1 and removed +0.1.0 labels Oct 8, 2024
Copy link

sonarcloud bot commented Oct 8, 2024

@mshabarov mshabarov merged commit 430f781 into main Oct 8, 2024
26 checks passed
@mshabarov mshabarov deleted the issues/3248-navigating-to-client-view branch October 8, 2024 06:05
vaadin-bot pushed a commit that referenced this pull request Oct 8, 2024
* fix: navigatin to client view from server

Navigation to the client view
using server navigate should
work normally and not try to
add layout for non layout
client view.

* remove class used for hilla compatibility
vaadin-bot added a commit that referenced this pull request Oct 8, 2024
* fix: navigatin to client view from server

Navigation to the client view
using server navigate should
work normally and not try to
add layout for non layout
client view.

* remove class used for hilla compatibility

Co-authored-by: caalador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants