fix: Layout should be collected as entyrpoint #20076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Layout annotated classes should be collected as entrypoints for production builds. Fixes #20074
caalador
force-pushed
the
issues/20074-layout-entrypoint
branch
from
5473f90 to
586d0b9
Compare
|
mshabarov
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Works as expected after this patch and also I don't see messages like:
2024-09-27T15:11:15.928+03:00 ERROR 10241 --- [nio-8080-exec-8] c.v.flow.component.internal.UIInternals : The component class com.vaadin.flow.component.applayout.DrawerToggle includes '@vaadin/app-layout/src/vaadin-drawer-toggle.js' but this file was not included when creating the production bundle. The component will not work properly. Check that you have a reference to the component and that you are not using it only through reflection. If needed add a @Uses(DrawerToggle.class) where it is used.
anymore.
LGTM.
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
Layout annotated classes should be collected as entrypoints for production builds. Fixes #20074
vaadin-bot
added a commit
that referenced
this pull request
Sep 27, 2024
Layout annotated classes should be collected as entrypoints for production builds. Fixes #20074 Co-authored-by: caalador <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layout annotated classes should be
collected as entrypoints for
production builds.
Fixes #20074