fix: Store layout packages #20075
Merged
fix: Store layout packages #20075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store layout packages in development mode reload cache as layouts may not be in same packages as routes. Fixes #20066
|
mshabarov
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Works as expected with this patch, LGTM.
To note: to reproduce this issue one should place route class to a separate folder/package, if the route and layout are in the same package, this problem does not show up.
Two questions to think about:
- how can this be covered by tests
- how we can prevent similar issues in the future, when we are adding new routing annotations?
|
Let discuss these question on Monday and meanwhile let me make another beta release. |
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
Store layout packages in development mode reload cache as layouts may not be in same packages as routes. Fixes #20066
vaadin-bot
added a commit
that referenced
this pull request
Sep 27, 2024
Store layout packages in development mode reload cache as layouts may not be in same packages as routes. Fixes #20066 Co-authored-by: caalador <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store layout packages
in development mode reload
cache as layouts may not be
in same packages as routes.
Fixes #20066