Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update title after navigation (#20047) (CP: 24.4) #20061

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Update the page title after
navigation has ended to
not have the wrong title in
history.

Fixes #19868
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) September 26, 2024 07:26
Copy link

github-actions bot commented Sep 26, 2024

Test Results

1 111 files  ±0  1 111 suites  ±0   1h 6m 34s ⏱️ -40s
7 058 tests ±0  7 009 ✅ ±0  49 💤 ±0  0 ❌ ±0 
7 431 runs   - 4  7 371 ✅  - 3  60 💤  - 1  0 ❌ ±0 

Results for commit 5359eeb. ± Comparison against base commit a99f8a7.

♻️ This comment has been updated with latest results.

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

Copy link

sonarcloud bot commented Sep 26, 2024

@vaadin-bot vaadin-bot merged commit 9978b1b into 24.4 Sep 26, 2024
26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20047-to-24.4-1727335257765 branch September 26, 2024 09:55
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.4.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants