Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide root output element (#20040) (CP: 24.5) #20044

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Ensures that root output element added for React router in Flow.tsx doesn't accidentally change the main layout with CSS rules targeting it.

Fixes: #19871
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) September 25, 2024 05:23
Copy link

sonarcloud bot commented Sep 25, 2024

Copy link

Test Results

1 137 files  ±0  1 137 suites  ±0   1h 9m 22s ⏱️ -53s
7 399 tests ±0  7 349 ✅ ±0  50 💤 ±0  0 ❌ ±0 
7 763 runs   - 3  7 703 ✅  - 3  60 💤 ±0  0 ❌ ±0 

Results for commit 6402922. ± Comparison against base commit d641601.

@vaadin-bot vaadin-bot merged commit 47cfb5c into 24.5 Sep 25, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20040-to-24.5-1727241360369 branch September 25, 2024 05:31
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.5.0.beta4 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants