Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate Control Center feature when used #20024

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

tltv
Copy link
Member

@tltv tltv commented Sep 23, 2024

Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with control-center-starter Vaadin platform dependency.

Fixes: #20013

Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency.

Fixes: #20013
@tltv tltv requested a review from mshabarov September 23, 2024 09:49
Copy link

github-actions bot commented Sep 23, 2024

Test Results

1 137 files  ±0  1 137 suites  ±0   1h 9m 38s ⏱️ + 2m 4s
7 399 tests ±0  7 349 ✅ ±0  50 💤 ±0  0 ❌ ±0 
7 761 runs  +8  7 701 ✅ +8  60 💤 ±0  0 ❌ ±0 

Results for commit 3dfeefd. ± Comparison against base commit 12633cd.

♻️ This comment has been updated with latest results.

mcollovati
mcollovati previously approved these changes Sep 23, 2024
Copy link

sonarcloud bot commented Sep 23, 2024

@mshabarov mshabarov merged commit 387f868 into main Sep 23, 2024
26 checks passed
@mshabarov mshabarov deleted the fix/20013-cc-feature-validation branch September 23, 2024 12:33
vaadin-bot pushed a commit that referenced this pull request Sep 23, 2024
* fix: Validate Control Center feature when used

Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency.

Fixes: #20013

* chore: formatting
vaadin-bot added a commit that referenced this pull request Sep 23, 2024
* fix: Validate Control Center feature when used

Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency.

Fixes: #20013

* chore: formatting

Co-authored-by: Tomi Virtanen <[email protected]>
Artur- pushed a commit that referenced this pull request Sep 24, 2024
* fix: Validate Control Center feature when used

Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency.

Fixes: #20013

* chore: formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open source Flow apps don't check Control Center's feature flag
4 participants