Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not throw if re-setting the login view #19996

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Sep 19, 2024

Fixes #19910

Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

github-actions bot commented Sep 19, 2024

Test Results

1 137 files  ± 0  1 137 suites  ±0   1h 9m 16s ⏱️ +2s
7 399 tests ± 0  7 349 ✅ + 1  50 💤 ±0  0 ❌  - 1 
7 761 runs  +13  7 701 ✅ +11  60 💤 +3  0 ❌  - 1 

Results for commit 5214dce. ± Comparison against base commit e7ac185.

♻️ This comment has been updated with latest results.

@Artur- Artur- requested a review from mcollovati September 19, 2024 12:41
@mcollovati mcollovati merged commit 5319304 into main Sep 20, 2024
26 checks passed
@mcollovati mcollovati deleted the no-throw-login-view-set branch September 20, 2024 05:30
vaadin-bot added a commit that referenced this pull request Sep 20, 2024
vaadin-bot added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when changing security configuration when using Hotswap Agent
3 participants