Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to TB 9.3.2 #19662

Merged
merged 1 commit into from
Jul 3, 2024
Merged

chore: upgrade to TB 9.3.2 #19662

merged 1 commit into from
Jul 3, 2024

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented Jul 3, 2024

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Copy link

sonarqubecloud bot commented Jul 3, 2024

Copy link

github-actions bot commented Jul 3, 2024

Test Results

1 127 files  ± 0  1 127 suites  ±0   1h 27m 37s ⏱️ + 2m 31s
7 297 tests ± 0  7 247 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 650 runs  +19  7 590 ✅ +19  60 💤 ±0  0 ❌ ±0 

Results for commit c70dd7b. ± Comparison against base commit a8c89b4.

@Artur- Artur- merged commit e427620 into main Jul 3, 2024
25 of 26 checks passed
@Artur- Artur- deleted the ZheSun88-patch-2 branch July 3, 2024 12:05
@vaadin-bot
Copy link
Collaborator

Hi @ZheSun88 and @Artur-, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick e427620
error: could not apply e427620... chore: upgrade to TB 9.3.2 (#19662)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@ZheSun88
Copy link
Contributor Author

ZheSun88 commented Jul 3, 2024

will do manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants