Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make index.tsx HMR compatible #19660

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: Make index.tsx HMR compatible #19660

merged 1 commit into from
Jul 3, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jul 3, 2024

Fixes #19657

Copy link

sonarqubecloud bot commented Jul 3, 2024

Copy link

github-actions bot commented Jul 3, 2024

Test Results

1 127 files  ± 0  1 127 suites  ±0   1h 24m 25s ⏱️ -27s
7 297 tests ± 0  7 247 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 664 runs  +27  7 604 ✅ +27  60 💤 ±0  0 ❌ ±0 

Results for commit 191180e. ± Comparison against base commit ba36f2e.

@Artur- Artur- requested a review from mshabarov July 3, 2024 11:15
@mshabarov mshabarov merged commit a8c89b4 into main Jul 3, 2024
25 of 26 checks passed
@mshabarov mshabarov deleted the index-tsx-hmr branch July 3, 2024 11:19
vaadin-bot pushed a commit that referenced this pull request Jul 3, 2024
vaadin-bot added a commit that referenced this pull request Jul 3, 2024
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha4 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index.tsx is not React HMR compatible
3 participants