Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove splash messages from dev tools #19558

Merged
merged 4 commits into from
Sep 16, 2024
Merged

chore: remove splash messages from dev tools #19558

merged 4 commits into from
Sep 16, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jun 11, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

Test Results

1 135 files  ± 0  1 135 suites  ±0   1h 27m 13s ⏱️ + 3m 24s
7 391 tests  -  1  7 341 ✅  -  1  50 💤 ±0  0 ❌ ±0 
7 734 runs   - 17  7 674 ✅  - 17  60 💤 ±0  0 ❌ ±0 

Results for commit 7e5874d. ± Comparison against base commit 5feb94b.

This pull request removes 1 test. 
com.vaadin.flow.uitest.ui.JavaLiveReloadIT ‑ splashMessageShownOnAutoReloadAndClosedOnBodyClick[any_Chrome_]

♻️ This comment has been updated with latest results.

@Artur- Artur- force-pushed the remove-splash-dev-tools branch from 6b7473f to af0f235 Compare July 3, 2024 10:33
@Artur- Artur- marked this pull request as ready for review July 3, 2024 10:34
mcollovati
mcollovati reviewed Jul 10, 2024
View reviewed changes
vaadin-dev-server/src/main/frontend/vaadin-dev-tools.ts Outdated
Comment on lines 744 to 759
document.body.addEventListener('focus', this.disableEventListener);
document.body.addEventListener('click', this.disableEventListener);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these addEventListener calls be removed, since the disableEventListener initialization has been deleted? Or maybe can disableEventListener be completely removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, seems like disableEventListener is no longer used at all

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcollovati
Copy link
Collaborator

@Artur- is this PR still relevant?

@mcollovati mcollovati force-pushed the remove-splash-dev-tools branch from 949e3ef to 45b2dc0 Compare September 13, 2024 06:54
@Artur-
Copy link
Member Author

Artur- commented Sep 13, 2024

Yes, although it is mostly code cleanup

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mshabarov mshabarov merged commit 4f69ad8 into main Sep 16, 2024
26 checks passed
@mshabarov mshabarov deleted the remove-splash-dev-tools branch September 16, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
+0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Artur- @mcollovati @vaadin-bot @mshabarov