Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jandex index to all necessary artifacts #9862

Closed
mvysny opened this issue Jan 21, 2021 · 3 comments · Fixed by vaadin/platform#2197
Closed

Add jandex index to all necessary artifacts #9862

mvysny opened this issue Jan 21, 2021 · 3 comments · Fixed by vaadin/platform#2197
Assignees
@caalador
Labels
enhancement quarkus

Comments

@mvysny
Copy link
Member

mvysny commented Jan 21, 2021

Vaadin 14.4.6: in order to support Quarkus, so-called Jandex index needs to be created. The reason is that Quarkus doesn't rely on classpath scanning to discover classes; instead it uses Jandex index. Alternatively, the jar files needs to have an empty beans.xml file present. Please see https://quarkus.io/guides/cdi-reference for more details.

These files need to be present in all flow-* jar files.
@mvysny mvysny mentioned this issue Jan 21, 2021
Closed
@mvysny mvysny mentioned this issue Jan 22, 2021
Closed
@mvysny
Copy link
Member Author

mvysny commented Feb 2, 2021

As a workaround I've created a project which builds the Vaadin Jandex index; I'm also publishing the artifact on jcenter and maven central. See https://github.com/mvysny/vaadin-jandex/ for more details.

@mstahv mstahv mentioned this issue May 18, 2021
Closed
18 tasks
@pleku pleku added the quarkus label May 24, 2021
@pleku
Copy link
Contributor

pleku commented Jun 10, 2021 •
edited
Loading

Acceptance Criteria

  • /platform project will build Jandex index for all necessary Vaadin artifacts
    • flow + flow-components artifacts, theme integrations, everything that has an annotation that the Vaadin application is going to read
    • not needed: cdi, spring, mpr ...
  • when a new artifact is added (flow or component or theme), it should be included to the index "automatically"
    • by depending on vaadin-core+vaadin it should be fine

@pleku pleku changed the title Add jandex index to all flow-* artifacts Add jandex index to all necessary artifacts Jun 10, 2021
@pleku pleku mentioned this issue Jun 10, 2021
Closed
@caalador caalador mentioned this issue Jun 15, 2021
Merged
caalador added a commit to vaadin/platform that referenced this issue Jun 16, 2021
@caalador
feat: Add generation of jandex index
161d553 
Generate jandex index package for
vaadin and vaadin-core.

Closes vaadin/flow#9862
@caalador caalador mentioned this issue Jun 16, 2021
Merged
@caalador caalador self-assigned this Jun 16, 2021
ZheSun88 pushed a commit to vaadin/platform that referenced this issue Jun 17, 2021
@caalador
feat: Add generation of jandex index (#2197)
593113d 
* feat: Add generation of jandex index

Generate jandex index package for
vaadin and vaadin-core.

Closes vaadin/flow#9862

* Add test for jandex modules
@pleku
Copy link
Contributor

pleku commented Jun 17, 2021

Not yet done as #11241 is pending

@pleku pleku reopened this Jun 17, 2021
@pleku pleku closed this as completed Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caalador caalador

Labels
enhancement quarkus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add generation of jandex index vaadin/platform
4 participants
@mvysny @pleku @caalador @denis-anisimov