-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong redirect after authentication when PUSH transport is WEBSOCKET #20575
Comments
It can also be replicate without OAUTH2, by creating a public view with a link to a protected route. |
mcollovati
changed the title
Wrong redirect after OAUTH2 authentication when PUSH transport is WEBSOCKET
Wrong redirect after authentication when PUSH transport is WEBSOCKET
Nov 29, 2024
mshabarov
moved this to 🔖 Normal Priority (P2)
in Vaadin Flow bugs & maintenance (Vaadin 10+)
Dec 3, 2024
mshabarov
moved this from 🪵Product backlog
to ⚒️ In progress
in Vaadin Flow ongoing work (Vaadin 10+)
Dec 4, 2024
mcollovati
added a commit
that referenced
this issue
Dec 10, 2024
When PUSH is enabled with websocket transport, the redirect URL to be used after a successfull login is not correctly computed because it is based on the PUSH servlet mapping. This change detects the situation and computes the correct URL. Fixes #20575
9 tasks
mcollovati
moved this from ⚒️ In progress
to 🔎Iteration reviews
in Vaadin Flow ongoing work (Vaadin 10+)
Dec 10, 2024
github-project-automation
bot
moved this from 🔖 Normal Priority (P2)
to ✅ Closed
in Vaadin Flow bugs & maintenance (Vaadin 10+)
Dec 11, 2024
github-project-automation
bot
moved this from 🔎Iteration reviews
to Done
in Vaadin Flow ongoing work (Vaadin 10+)
Dec 11, 2024
vaadin-bot
pushed a commit
that referenced
this issue
Dec 11, 2024
When PUSH is enabled with websocket transport, the redirect URL to be used after a successfull login is not correctly computed because it is based on the PUSH servlet mapping. This change detects the situation and computes the correct URL. Fixes #20575
vaadin-bot
pushed a commit
that referenced
this issue
Dec 11, 2024
When PUSH is enabled with websocket transport, the redirect URL to be used after a successfull login is not correctly computed because it is based on the PUSH servlet mapping. This change detects the situation and computes the correct URL. Fixes #20575
vaadin-bot
pushed a commit
that referenced
this issue
Dec 11, 2024
When PUSH is enabled with websocket transport, the redirect URL to be used after a successfull login is not correctly computed because it is based on the PUSH servlet mapping. This change detects the situation and computes the correct URL. Fixes #20575
vaadin-bot
added a commit
that referenced
this issue
Dec 11, 2024
… 24.4) (#20678) * fix: fix redirect URL for PUSH with websocket transport (#20666) When PUSH is enabled with websocket transport, the redirect URL to be used after a successfull login is not correctly computed because it is based on the PUSH servlet mapping. This change detects the situation and computes the correct URL. Fixes #20575 * fix version --------- Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this issue
Dec 11, 2024
… 24.6) (#20676) * fix: fix redirect URL for PUSH with websocket transport (#20666) When PUSH is enabled with websocket transport, the redirect URL to be used after a successfull login is not correctly computed because it is based on the PUSH servlet mapping. This change detects the situation and computes the correct URL. Fixes #20575 * fix version --------- Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this issue
Dec 11, 2024
… 24.5) (#20677) * fix: fix redirect URL for PUSH with websocket transport (#20666) When PUSH is enabled with websocket transport, the redirect URL to be used after a successfull login is not correctly computed because it is based on the PUSH servlet mapping. This change detects the situation and computes the correct URL. Fixes #20575 * fix version --------- Co-authored-by: Marco Collovati <[email protected]>
This ticket/PR has been released with Vaadin 24.6.0.rc1 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
When the Vaadin application is configured with
VaadinWebSecurity
, OAUTH2 and WEBSOCKET PUSH transport, the URL stored for redirection after successful login is incorrect; it points to the PUSH mapping instead of the requested page.For example, when navigating to a protected route
/
, the browser is redirected to the login page, but the stored URL ishttp://localhost:8080/VAADIN/push
instead ofhttp://localhost:8080/
. After entering correct credentials, the browser is redirected to/VAADIN/push
, resulting in a 404 error page.Expected behavior
After successful login, the original request page should be shown. In the example above, the browser should be redirected to http://localhost:8080/.
Minimal reproducible example
@Push(transport = Transport.WEBSOCKET)
toAppShellConfigurator
implementor@PermitAll
/VAADIN/push
instead of the protected view.Versions
The text was updated successfully, but these errors were encountered: