Hotswap does not take into account adding or removing @Layout #20111
Assignees
Comments
mshabarov
moved this to 🔖 High Priority (P1)
in Vaadin Flow bugs & maintenance (Vaadin 10+)
mcollovati
moved this from 🟢Ready to Go
to ⚒️ In progress
in Vaadin Flow ongoing work (Vaadin 10+)
mcollovati
added a commit
that referenced
this issue
Oct 3, 2024
When a [At]Layout annotated class is modified, the changes are not propagated to the route registry after hotswap happens. This change updates Route registry layouts configuration and re-registers routes potentially impacted by the change to apply the new settings. It also checks the route target chain for active UIs in order to trigger a page refresh if the layout changes should be applied. Fixes #20111
9 tasks
mcollovati
added a commit
that referenced
this issue
Oct 3, 2024
When a [At]Layout annotated class is modified, the changes are not propagated to the route registry after hotswap happens. This change updates Route registry layouts configuration and re-registers routes potentially impacted by the change to apply the new settings. It also checks the route target chain for active UIs in order to trigger a page refresh if the layout changes should be applied. Fixes #20111
mcollovati
added a commit
that referenced
this issue
Oct 4, 2024
When a [At]Layout annotated class is modified, the changes are not propagated to the route registry after hotswap happens. This change updates Route registry layouts configuration and re-registers routes potentially impacted by the change to apply the new settings. It also checks the route target chain for active UIs in order to trigger a page refresh if the layout changes should be applied. Fixes #20111
mshabarov
pushed a commit
that referenced
this issue
Oct 7, 2024
* fix: reload route configuration upon layout changes When a [At]Layout annotated class is modified, the changes are not propagated to the route registry after hotswap happens. This change updates Route registry layouts configuration and re-registers routes potentially impacted by the change to apply the new settings. It also checks the route target chain for active UIs in order to trigger a page refresh if the layout changes should be applied. Fixes #20111 * clean up and remove useless duplicated test * revert change * handle layout changes for Hilla views * fix assertion parameters oreder * remove commented code
github-project-automation
bot
moved this from ⚒️ In progress
to Done
in Vaadin Flow ongoing work (Vaadin 10+)
github-project-automation
bot
moved this from 🔖 High Priority (P1)
to ✅ Closed
in Vaadin Flow bugs & maintenance (Vaadin 10+)
vaadin-bot
pushed a commit
that referenced
this issue
Oct 7, 2024
* fix: reload route configuration upon layout changes When a [At]Layout annotated class is modified, the changes are not propagated to the route registry after hotswap happens. This change updates Route registry layouts configuration and re-registers routes potentially impacted by the change to apply the new settings. It also checks the route target chain for active UIs in order to trigger a page refresh if the layout changes should be applied. Fixes #20111 * clean up and remove useless duplicated test * revert change * handle layout changes for Hilla views * fix assertion parameters oreder * remove commented code
mcollovati
added a commit
that referenced
this issue
Oct 7, 2024
* fix: reload route configuration upon layout changes When a [At]Layout annotated class is modified, the changes are not propagated to the route registry after hotswap happens. This change updates Route registry layouts configuration and re-registers routes potentially impacted by the change to apply the new settings. It also checks the route target chain for active UIs in order to trigger a page refresh if the layout changes should be applied. Fixes #20111 * clean up and remove useless duplicated test * revert change * handle layout changes for Hilla views * fix assertion parameters oreder * remove commented code
mcollovati
added a commit
that referenced
this issue
Oct 7, 2024
* fix: reload route configuration upon layout changes When a [At]Layout annotated class is modified, the changes are not propagated to the route registry after hotswap happens. This change updates Route registry layouts configuration and re-registers routes potentially impacted by the change to apply the new settings. It also checks the route target chain for active UIs in order to trigger a page refresh if the layout changes should be applied. Fixes #20111 * clean up and remove useless duplicated test * revert change * handle layout changes for Hilla views * fix assertion parameters oreder * remove commented code
|
This ticket/PR has been released with Vaadin 24.5.0.beta6 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
Adding or removing the
@Layoutannotation on a class implementingRouterLayouthas no effect when using HotSwapAgent. You need to restart the server to see the change.Expected behavior
Expected that a server restart is not needed
Minimal reproducible example
24.5 pre project from Start
Versions
The text was updated successfully, but these errors were encountered: