-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it compatible with numpy > 1.16 #28
base: master
Are you sure you want to change the base?
Make it compatible with numpy > 1.16 #28
Conversation
Is it like #27 ? |
Yes, I think is the same but the solution is slightly different. |
I can confirm that this patch fixes the compatibility issue with numpy > 1.16. Hope to see it in the upstream! |
This one-line fix is an open issue for a year now. Maybe add some contributors? :-) |
@vMeijin this is a major issue since numpy==1.6 can't be compiled on some modern systems anymore with recent Python versions (I'm using MacOS). Could you please just press the "Merge" button? :) |
@rpcope1 maybe could merge it? Thanks. |
@SaladePengouin I wish I could, I don't have the ability to merge. I haven't thought about library for almost a decade now, but this sounds like a real challenge. I don't know if there's a preferred fork or something, otherwise I might be able to take a stab at it. |
In version of numpy higher than 1.16 the third argument of linspace is not be interpreted as integer and would produce and error.
https://docs.scipy.org/doc/numpy/release.html?highlight=histogram
Then matrix d_mat need to be initialized as a integer type.