Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

survey only parameters for relations #4998

Merged
merged 6 commits into from
Oct 3, 2024
Merged

survey only parameters for relations #4998

merged 6 commits into from
Oct 3, 2024

Conversation

Mh-Asmi
Copy link
Contributor

@Mh-Asmi Mh-Asmi commented Oct 3, 2024

This pull request makes the following changes:

  • add only for survey relations
  • update paging for survey

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

Copy link

linear bot commented Oct 3, 2024

@Mh-Asmi Mh-Asmi requested review from Angamanga, ushahidlee and tuxpiper and removed request for Angamanga October 3, 2024 10:40
Copy link
Member

@tuxpiper tuxpiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that I need to spend some more time with v5 code , there's only so much I understand here.
In any case, it looks good to me 👍

@Mh-Asmi Mh-Asmi merged commit 06bab6a into develop Oct 3, 2024
4 checks passed
Copy link

sentry-io bot commented Oct 7, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Ushahidi\Core\Exception\NotFoundException: Survey not found Ushahidi\Modules\V5\Http\Controllers\SurveyCont... View Issue
  • ‼️ Ushahidi\Core\Exception\NotFoundException: Survey not found Ushahidi\Modules\V5\Http\Controllers\SurveyCont... View Issue
  • ‼️ Ushahidi\Core\Exception\NotFoundException: Survey not found Ushahidi\Modules\V5\Http\Controllers\SurveyCont... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants