Feature/move over law #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cbfc02b.
kjrush
reviewed
Dec 6, 2024
| log.debug("Added new ns3 registration for vehicle {}", vehicleRole); | ||
| } | ||
| if(bridgeRegistrationList.containsKey(vehicleRole)){ | ||
| log.debug("Found bridge registration of vehicle {}, making a carma messenger instance now", vehicleRole); |
There was a problem hiding this comment.
This log says it's making a new instance now, but doesn't seem to trigger anything?
| log.debug("Added new bridge registration for vehicle {}", vehicleRole); | ||
| } | ||
| if(ns3RegistrationList.containsKey(vehicleRole)){ | ||
| log.debug("Found ns3 registration of vehicle {}, making a carma messenger instance now", vehicleRole); |
There was a problem hiding this comment.
Same as above, not sure how this functions correctly.
...ion/fed/mosaic-sumo/src/main/java/org/eclipse/mosaic/fed/sumo/ambassador/SumoAmbassador.java
Show resolved
Hide resolved
| @@ -40,7 +40,7 @@ | |||
|
|
|||
|
|
|||
| public class CommonInstanceManager<T extends CommonInstance, R extends CommonRegistrationMessage> { | |||
| protected Map<String, T> managedInstances = new HashMap<>(); | |||
| public Map<String, T> managedInstances = new HashMap<>(); | |||
There was a problem hiding this comment.
What's the rationale for making this public as opposed to adding a getInstances() accessor method or something like that?
|
kjrush
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This is for adding new code in carma messenger ambassador, sumo ambassador and carma messenger vehicle plugin to prepare for the carma messenger integration test
Related GitHub Issue
Related Jira Key
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: