chore(vue,svelte,core): Update TypeScript and fix missing AnyVariables generics #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
approved these changes
Nov 28, 2022
kitten
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is essentially a follow-up to #2607. We previously missed a couple of places that needed to be ported over from
Variables = objecttoVariables extends AnyVariables = AnyVariablesand the new TypeScript upgrade was blocked by these fixes.Essentially, all that was needed was to fix these up. I suspect, as one would correctly assume,
objectis now not an alias forany(hence includingvoid | undefined) but an alias forRecord<string, any>to excluded void-like values.Set of changes
@urql/vue@urql/svelte@urql/exchange-graphcache(doesn't affect public API)