Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:(issue_1916) Fix subcommand flag completion #1918

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

dearchap
Copy link
Contributor

@dearchap dearchap commented Jun 1, 2024

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1916

Special notes for your reviewer:

(fill-in or delete this section)

Removed unnecessary redirection for DefaultCompleteWithFlags function

Testing

(fill-in or delete this section)

go test -run=TestCompletionSubcommand

Release Notes

(REQUIRED)


@dearchap dearchap requested a review from a team as a code owner June 1, 2024 15:21
@dearchap dearchap merged commit 1210bdf into urfave:main Jun 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should I expect completion of nested command's flags to work?
3 participants