Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve .xyz as UNS domains #263

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Resolve .xyz as UNS domains #263

merged 4 commits into from
Nov 14, 2024

Conversation

iurevych
Copy link
Contributor

Background / Changes

This PR resolves .xyz as UNS domains, instead of throwing an error of an unsupported domain.

Code Review

This Pull Request was thoroughly reviewed and meets all Code Review Standards pertaining to:

  • Implementation - satisfied acceptance criteria
  • Communication - notified engineers/stakeholders about impactful changes
  • Error handling - handled, logged & alerted on errors
  • Documentation - wrote readable code & commits, documented unintuitive code
  • Testing - unit & E2E test coverage, tested in staging, DB migrations backwards compatible
  • Security - sanitized inputs, vetted dependencies, validated/secured API requests, no committed secrets
  • Performance - optimized expensive algorithms & database queries

Please select all applied standards relevant to this PR.

Confirmation

  • Assignee Confirmation - I (the author) have filled out the template above
  • Reviewer Confirmation - I (a/the reviewer) confirm 1) the author has filled out the template and checked the box that says Assignee Confirmation 2) I reviewed the code and selected all applicable items in the code review section.

@iurevych iurevych requested a review from sammyluo November 14, 2024 09:13
@iurevych iurevych self-assigned this Nov 14, 2024
@sammyluo sammyluo merged commit f99c503 into master Nov 14, 2024
5 checks passed
@sammyluo sammyluo deleted the iurevych/fix-xyz-tld branch November 14, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants