fix: Workaround non-UIElement UIViews in Grid layout #18470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18470/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18470/index.html |
|
@Mergifyio backport release/stable/5.5 |
|
@Mergifyio backport release/stable/5.4 |
✅ Backports have been created
|
✅ Backports have been created
|
|
The build 143618 found UI Test snapshots differences: Details
|
ramezgerges
approved these changes
Oct 16, 2024
This was referenced Oct 16, 2024
jeromelaban
added a commit
that referenced
this pull request
Oct 16, 2024
…5.5/pr-18470 fix: Workaround non-UIElement UIViews in Grid layout (backport #18470)
jeromelaban
added a commit
that referenced
this pull request
Oct 16, 2024
…5.4/pr-18470 fix: Workaround non-UIElement UIViews in Grid layout (backport #18470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #17997, closes #14013
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Focusing a text input on iOS causes the framework to temporarily add a non-UIElement child to the parent's
Grid, which is then surfaced to theGridas anullWhat is the new behavior?
No longer crashing. This is a workaround, ideally we would want to ensure that
Childrenas aUIElementCollectiononly reflects the actualUIElementsin theChildrenShadow. This however means more complex logic to properly handle indexes, etc. This workaround seems to be sufficient for now to handle the cases we encountered. Created #18474 to track thisPR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):