-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Implementation for Polyline and shapes sample #1813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iguins
added
the
platform/wasm 🌐
Categorizes an issue or PR as relevant to the WebAssembly platform
label
Oct 11, 2019
It seems that no relevant of the UI tests were affected by this change, could you add some? |
github-actions
bot
added
the
area/automation
Categorizes an issue or PR as relevant to project automation
label
Oct 11, 2019
src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Shapes/ShapeControlsPage.xaml
Outdated
Show resolved
Hide resolved
src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Shapes/EllipsePage.xaml.cs
Outdated
Show resolved
Hide resolved
src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Shapes/PolygonePage.xaml
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
platform/android 🤖
Categorizes an issue or PR as relevant to the Android platform
label
Oct 15, 2019
carldebilly
reviewed
Oct 16, 2019
src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Shapes/LinePage.xaml.cs
Outdated
Show resolved
Hide resolved
src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Shapes/PolygonePage.xaml.cs
Outdated
Show resolved
Hide resolved
src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Shapes/PolygonePage.xaml.cs
Outdated
Show resolved
Hide resolved
Iguins
force-pushed
the
dev/guen/WASMShapes
branch
from
October 16, 2019 15:52
c680461
to
9666f21
Compare
jeromelaban
reviewed
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is update the dynamic api of shapes, adding tests that modify a shape will be needed as well. (e.g. Create a shape, screenshot, update the shape, screenshot, etc...)
Iguins
force-pushed
the
dev/guen/WASMShapes
branch
from
October 16, 2019 19:48
1f6b0fc
to
bed160f
Compare
carldebilly
reviewed
Oct 17, 2019
src/SamplesApp/SamplesApp.UITests/Windows_UI_Xaml_Shapes/Shapes_Tests.cs
Outdated
Show resolved
Hide resolved
Iguins
changed the title
[WASM] Basic Implementation for Polyline
Basic Implementation for Polyline and shapes sample
Oct 17, 2019
Iguins
force-pushed
the
dev/guen/WASMShapes
branch
from
October 17, 2019 19:09
97b534a
to
090a606
Compare
jeromelaban
reviewed
Oct 18, 2019
src/SamplesApp/SamplesApp.UITests/Windows_UI_Xaml_Shapes/Shapes_Tests.cs
Outdated
Show resolved
Hide resolved
jeromelaban
reviewed
Oct 21, 2019
src/SamplesApp/SamplesApp.UITests/Windows_UI_Xaml_Shapes/Shapes_Tests.cs
Outdated
Show resolved
Hide resolved
Iguins
force-pushed
the
dev/guen/WASMShapes
branch
from
October 22, 2019 17:45
f60d6b0
to
2e7ab1b
Compare
carldebilly
approved these changes
Oct 22, 2019
/azp run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/automation
Categorizes an issue or PR as relevant to project automation
platform/android 🤖
Categorizes an issue or PR as relevant to the Android platform
platform/wasm 🌐
Categorizes an issue or PR as relevant to the WebAssembly platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Not Implemented exception for polyline
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable): undisclosed