Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Implementation for Polyline and shapes sample #1813

Merged
merged 15 commits into from
Oct 22, 2019
Merged

Conversation

Iguins
Copy link
Contributor

@Iguins Iguins commented Oct 11, 2019

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Not Implemented exception for polyline

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable): undisclosed

@Iguins Iguins added the platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform label Oct 11, 2019
@jeromelaban
Copy link
Member

It seems that no relevant of the UI tests were affected by this change, could you add some?

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Oct 11, 2019
@Iguins Iguins self-assigned this Oct 15, 2019
@github-actions github-actions bot added the platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform label Oct 15, 2019
@Iguins Iguins force-pushed the dev/guen/WASMShapes branch from c680461 to 9666f21 Compare October 16, 2019 15:52
Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is update the dynamic api of shapes, adding tests that modify a shape will be needed as well. (e.g. Create a shape, screenshot, update the shape, screenshot, etc...)

src/Uno.UI/UI/Xaml/Shapes/Polyline.cs Show resolved Hide resolved
@Iguins Iguins changed the title [WASM] Basic Implementation for Polyline Basic Implementation for Polyline and shapes sample Oct 17, 2019
@Iguins Iguins force-pushed the dev/guen/WASMShapes branch from 97b534a to 090a606 Compare October 17, 2019 19:09
@Iguins Iguins force-pushed the dev/guen/WASMShapes branch from f60d6b0 to 2e7ab1b Compare October 22, 2019 17:45
@Iguins
Copy link
Contributor Author

Iguins commented Oct 22, 2019

/azp run

@Iguins Iguins merged commit 6796247 into master Oct 22, 2019
@Iguins Iguins deleted the dev/guen/WASMShapes branch October 22, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants