Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for SelectorItem as DataTemplate #2477

Closed
4 of 8 tasks
jeromelaban opened this issue Jan 13, 2020 · 0 comments · Fixed by #3713
Closed
4 of 8 tasks

Support for SelectorItem as DataTemplate #2477

jeromelaban opened this issue Jan 13, 2020 · 0 comments · Fixed by #3713
Assignees
@carldebilly @davidjohnoliver
Labels
kind/enhancement New feature or request project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...)
Milestone
3.1

Comments

@jeromelaban
Copy link
Member

What would you like to be added:

Add support for ItemsControl and derivatives to support the ability for the ItemTemplate to provide a container and override the default container.

Why is this needed:

Overriding the default template for a NavigationView menu items is done through such an override.

For which Platform:

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Windows
  • Build tasks
  • Solution Templates

Anything else we need to know?
@jeromelaban jeromelaban added the kind/enhancement New feature or request label Jan 13, 2020
@jeromelaban jeromelaban mentioned this issue Jan 13, 2020
Closed
8 tasks
jeromelaban added a commit that referenced this issue Jan 13, 2020
@jeromelaban
Add workaround for NavigationView ItemSource and template
3b1a850 
See #2477
jeromelaban added a commit that referenced this issue Jan 13, 2020
@jeromelaban
Add workaround for NavigationView ItemSource and template
3616fc0 
See #2477
@jeromelaban jeromelaban mentioned this issue Jan 13, 2020
Merged
7 tasks
@davidjohnoliver davidjohnoliver self-assigned this Jul 31, 2020
@jeromelaban jeromelaban mentioned this issue Sep 1, 2020
Merged
6 tasks
@carldebilly carldebilly added this to the 3.1 milestone Sep 1, 2020
@agneszitte agneszitte added the project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carldebilly carldebilly

@davidjohnoliver davidjohnoliver

Labels
kind/enhancement New feature or request project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...)
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

feat: Add support DataTemplate is container host unoplatform/uno
4 participants
@carldebilly @jeromelaban @davidjohnoliver @agneszitte