Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some crashes and deadlocks #10

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

pondy
Copy link
Contributor

@pondy pondy commented Mar 15, 2013

Here are some changes to remove compile warnings and fix stability problems. The highlights are:

  • Make the frontend check for ERROR_IO_PENDING before waiting for a write to complete. This fixes a hang in the front end went the interperter process dies as just the wrong time.
  • Don't crash the interpreter if the stack size is > 100 or we could not determine the name of a script at a certain level in the stack.
  • Don't deadlock the interperter if __tostring or __towatch calls lua_error() while stopped on a breakpoint.

@ghost ghost assigned dushan42 May 14, 2013
@dushan42
Copy link
Contributor

I know it's been a while but is there any chance you could break the fixes into individual pull requests? I believe the ERROR_IO_PENDING fix is in but the other stuff isn't and is non-trivial to merge at this point.
Thanks!
-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants