fix: tighten schema definition types #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
nuxt/nuxt#22340
β Type of change
π Description
We currently have an issue with newer typescript versions whereby
$resolve
(and similar 'magic' keys) are not being typed correctly because they could also be equally well typed withany
. This makes a change to SchemaDefinition types that removes theany
signature in favour of explicitJSValue
types (but only for keys that do not match$resolve
, etc.).This increases type safety and may result in an error when an
unknown
property is assigned to a schema value. But nevertheless this is worth testing to ensure no (unintended) regressions.π Checklist