feat: add otp utils #37
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Jan 12, 2024
src/otp/base32.ts
Outdated
| // Simple implementation based of RFC 4648 for base32 encoding and decoding | ||
|
|
||
| const pad = "="; | ||
| const base32alphaMap = { |
There was a problem hiding this comment.
We might try to compress it using an array.
There was a problem hiding this comment.
doable, though the reference and number of operation would remain similar during encode, saves a bit more during decode so I've pushed the changes
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Adds helpers for TOTP generation using
uncryptoas the base📝 Checklist
➕ Additional Notes
The
unbuildsetup builds but still has a commonjs resolver error which I'm assuming is from the upstream repo, so fixing that first, the PR is in draft till then