fix(parse): handle no zero in _readString #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Sorry for no repro or tests, but I noticed this bug which should be simple to fix)
view.indexOf(0)could return-1if there's no0, e.g. if the entireUint8Arrayis filled up. If it's-1,view.slice(0, i)would be incorrect because it removes the last item in theUint8Array.In this PR, if
-1is found, we don't slice at all. And use the originalviewinstead. I found this bug causing thetarFile.nameto be missing the last character otherwise, e.g..../pkg/package.jso(missingn)